Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
karapace/schema_models.py
Outdated
| if dependencies: | ||
| merged_schema = "" | ||
| for dependency in dependencies.values(): | ||
| merged_schema += self.builder(dependency.schema.schema_str, dependency.schema.dependencies) + ",\n" |
There was a problem hiding this comment.
Can we please change this to a loop based approach supported by a stack or a queue, (depending on the propagation). This is to safe guard against a large nested schema.
|
Would it be possible to add new unit tests to cover the changes in schema_models.py, schema_reader.py, schema_registry_apis.py? Seems only integration tests have been added for that stuff |
Yes, it is possible. But creating tests may become an endless process if we do not follow the Karapace test practice. They have no unit tests for schema_registry_api.py, and the tests for schema_models and schema_reader do not look meticulous. However, they have good test coverage for the functional parts of schema storing, parsing, compatibility, etc. So we focused on these tests and now have integration and unit tests for Avro schemas functionality. |
libretto
force-pushed
the
avro_references2
branch
2 times, most recently
from
f0f9450 to
0167a75
Compare
libretto
force-pushed
the
avro_references2
branch
3 times, most recently
from
9cac0ba to
f4346ea
Compare
libretto
force-pushed
the
avro_references2
branch
from
f4346ea to
5ab6ba0
Compare
4 participants
About this change - What it does
References: #xxxxx
Why this way